Working FX handling#170
Conversation
|
good call @bouweandela we should put this in a new PR 🍺 |
|
OK @mattiarighi what's the verdikt? 👍 or 👎 ? |
|
@bouweandela dismissed his review, so you have to wait for his approval... |
|
@bouweandela ye olde gnashgab, what say you? 🍺 |
|
If you don't want to solve d2898db#issuecomment-531160887 in this pull request, can you at least make an issue for it? |
yes, I will PR the feathers out of it in a different PR, way too much stuff in this one |
I opened issue #250 so that we won't forget. |
cheers @mattiarighi 🍺 |
|
Can you do it pls. Am travelling to Paris today and dont have my laptop
with me 🍺
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
…On Mon, 30 Sep 2019, 14:59 Mattia Righi, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In esmvalcore/_recipe.py
<#170 (comment)>
:
> @@ -910,6 +943,9 @@ def _initialize_variables(self, raw_variable, raw_datasets):
variable = deepcopy(raw_variable)
variable.update(dataset)
variable['recipe_dataset_index'] = index
+ # preserve the MIP from RAW in variable object
+ if 'mip' in raw_variable:
@valeriupredoi <https://github.com/valeriupredoi> can you revert this
change as discussed? We need to finalize this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#170?email_source=notifications&email_token=AG5EFI6HDTWNOFRMTVASEOTQMIA35A5CNFSM4IEPROZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGKUGQQ#discussion_r329592230>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG5EFI6RRS4IACEARK2VX5DQMIA35ANCNFSM4IEPROZQ>
.
|
|
Soz, man, going to the CRESCENDO meeting so I actually wanna listen to the
talks, hence no laptop 😁
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
…On Mon, 30 Sep 2019, 15:00 Valeriu Predoi, ***@***.***> wrote:
Can you do it pls. Am travelling to Paris today and dont have my laptop
with me 🍺
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
On Mon, 30 Sep 2019, 14:59 Mattia Righi, ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In esmvalcore/_recipe.py
> <#170 (comment)>
> :
>
> > @@ -910,6 +943,9 @@ def _initialize_variables(self, raw_variable, raw_datasets):
> variable = deepcopy(raw_variable)
> variable.update(dataset)
> variable['recipe_dataset_index'] = index
> + # preserve the MIP from RAW in variable object
> + if 'mip' in raw_variable:
>
> @valeriupredoi <https://github.com/valeriupredoi> can you revert this
> change as discussed? We need to finalize this.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#170?email_source=notifications&email_token=AG5EFI6HDTWNOFRMTVASEOTQMIA35A5CNFSM4IEPROZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGKUGQQ#discussion_r329592230>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AG5EFI6RRS4IACEARK2VX5DQMIA35ANCNFSM4IEPROZQ>
> .
>
|
|
Done. Waiting for final approval... |
|
Boss!
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
…On Mon, 30 Sep 2019, 15:05 Mattia Righi, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In esmvalcore/_recipe.py
<#170 (comment)>
:
> @@ -910,6 +943,9 @@ def _initialize_variables(self, raw_variable, raw_datasets):
variable = deepcopy(raw_variable)
variable.update(dataset)
variable['recipe_dataset_index'] = index
+ # preserve the MIP from RAW in variable object
+ if 'mip' in raw_variable:
Change reverted.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#170?email_source=notifications&email_token=AG5EFIYKMOZUNK4UIBEFBWTQMIBULA5CNFSM4IEPROZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGKVKFY#discussion_r329595626>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG5EFIZ5PM3GJLZWR5ARGJLQMIBULANCNFSM4IEPROZQ>
.
|
|
@valeriupredoi please close the related issues. |
|
Wohoo, I will, on Friday when I is back. Cheers, man!
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
…On Mon, 30 Sep 2019, 16:50 Mattia Righi, ***@***.***> wrote:
@valeriupredoi <https://github.com/valeriupredoi> please close the
related issues.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#170?email_source=notifications&email_token=AG5EFI5SDWLYL6WXNM6J2ALQMIG3BA5CNFSM4IEPROZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD755KRI#issuecomment-536597829>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG5EFI7FVXGC6EFEZQG73CTQMIG3BANCNFSM4IEPROZQ>
.
|
OK chaps @bouweandela @zklaus @ledm here is the long promised implementation of fx vars handling: this is a sister PR of #21 but with much improved user interface and functionality. It does the following:
get_input_filelistis used; also removes the special entries for fx files/dirs inconfig-developer;fx_filesdictionary in the variable (see NOTE below);NOTE:
mask_landseaormask_landseaice, all they have to do is to set these preproc steps in the preprocessor; no more need to specify thefx_filesin variabl; the code will automatically grab the fx files for masking BUT it will apply the masks from those files WITHOUT doing any CMOR checks/fixes or any preprocessor on the fx files (basically what we had before). The next step will be to implement this functionality (allow preprocessing on fx files that are used in the preprocessor) but that is absolutely non-trival.